-
Notifications
You must be signed in to change notification settings - Fork 3
Conversation
Codecov Report
@@ Coverage Diff @@
## master #51 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 14 14
Lines 733 733
======================================
Misses 733 733 Continue to review full report at Codecov.
|
@PerchunPak add translations. RU:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I should look in it better.
So this will be easy to translate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorrect. See DM.
Because it anyway will be changed in `final` step
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I think it's ready. @cofob, hoping I didn't break anything, and waiting for your ok
before merge it to master.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is useless. Please remove.
Last step is always final. No need for this.
You can merge. Looks good. |
Важный check-list
CHANGELOG.md
и добавил номер PR туда.make test
.closes #48