Skip to content
This repository has been archived by the owner on Feb 4, 2024. It is now read-only.

Optimize Docker Container #51

Merged
merged 26 commits into from
Jun 18, 2022
Merged

Optimize Docker Container #51

merged 26 commits into from
Jun 18, 2022

Conversation

cofob
Copy link
Contributor

@cofob cofob commented Jun 17, 2022

Важный check-list

  • Я написал подробное описание моих изменений.
  • Я написал подробную причину моих изменений.
  • Я точно прочитал и использовал все пункты этого списка.
  • Я записал изменение в CHANGELOG.md и добавил номер PR туда.
  • Изменения успешно проходят все этапы make test.

closes #48

@PerchunPak PerchunPak changed the title Updated dockerfile Update dockerfile Jun 17, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2022

Codecov Report

Merging #51 (c5d7fc0) into master (be68ee0) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master     #51   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files          14      14           
  Lines         733     733           
======================================
  Misses        733     733           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be68ee0...c5d7fc0. Read the comment docs.

@cofob
Copy link
Contributor Author

cofob commented Jun 17, 2022

@PerchunPak add translations.

RU:

Запуск в podman настолько же прост как и в Docker. Всё сводиться к тому что вы заменяете во всех командах ``docker`` на ``podman``. Сложность может возникнуть только с автоматическим запуском, но podman предоставляет все необходимые инструменты для этого, с systemd это просто 1 команда для генерации юнита, запустите ``podman generate systemd --restart-policy always --name pingerbot > /etc/systemd/system/pingerbot.service``. После этого включите сервис ``systemctl daemon-reload && systemctl enable --now pingerbot``.
Начиная с версии 0.4.0 контейнер работает в rootless режиме, что означает, что если вы используете версию sqlite и внешний volume, вам необходимо предоставить права на папку. Это можно сделать с помощью команды ``chown -R 5000:500 <ваша папка>``.

Copy link
Owner

@PerchunPak PerchunPak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I should look in it better.

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
docs/pages/docker.rst Outdated Show resolved Hide resolved
@PerchunPak PerchunPak changed the title Update dockerfile Optimize Docker Container Jun 17, 2022
Copy link
Contributor Author

@cofob cofob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect. See DM.

Copy link
Owner

@PerchunPak PerchunPak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I think it's ready. @cofob, hoping I didn't break anything, and waiting for your ok before merge it to master.

Copy link
Contributor Author

@cofob cofob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is useless. Please remove.

Last step is always final. No need for this.

@PerchunPak
Copy link
Owner

This is useless. Please remove.

Last step is always final. No need for this.

This is for pretty display during docker build:
image
Instead of
image

@cofob
Copy link
Contributor Author

cofob commented Jun 18, 2022

Okay, I think it's ready. @cofob, hoping I didn't break anything, and waiting for your ok before merge it to master.

You can merge. Looks good.

@PerchunPak PerchunPak merged commit 8bdae94 into PerchunPak:master Jun 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Контейнер неоптимизирован
3 participants