Update README.md #133
Merged
Update README.md #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Performance test results: |
dutow
reviewed
Mar 4, 2024
README.md
Outdated
| This datafile is created and managed by Postgres, the only requirement is that postgres should be able to write to the specified path. | ||
|
|
||
| This setup is intended for developmenet, and stores the keys unencrypted in the specified data file. | ||
| **Note: This setup is intended for development and stores the keys unencrypted in the specified data file.** |
There was a problem hiding this comment.
This note should be at the file provider function, not after set master key.
dAdAbird
reviewed
Mar 4, 2024
README.md
Outdated
| "provider": "file", | ||
| "datafile": "/tmp/pgkeyring" | ||
| } | ||
| **Example**: Add a `File` key provider and name it `file-vault`. |
There was a problem hiding this comment.
Given that we have a Vault provider, the file-vault name looks a bit confusing.
dAdAbird
reviewed
Mar 5, 2024
Co-authored-by: Andrew Pogrebnoi <absourd.noise@gmail.com>
Co-authored-by: Andrew Pogrebnoi <absourd.noise@gmail.com>
Co-authored-by: Andrew Pogrebnoi <absourd.noise@gmail.com>
Co-authored-by: Andrew Pogrebnoi <absourd.noise@gmail.com>
Co-authored-by: Andrew Pogrebnoi <absourd.noise@gmail.com>
Co-authored-by: Andrew Pogrebnoi <absourd.noise@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the readme to reflect changes made to set up key providers and master key.