Minimal working prototype for SMGR + Event trigger + keyring encryption #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dAdAbird
approved these changes
May 30, 2024
codeforall
reviewed
Jun 3, 2024
src/access/pg_tde_tdemap.c
Outdated
| if (master_key == NULL) | ||
| { | ||
| ereport(ERROR, | ||
| (errmsg("failed to retrieve master key"))); | ||
| (errmsg("1 - failed to retrieve master key"))); |
There was a problem hiding this comment.
I believe this 1 is left out as part of some debugging code?
codeforall
approved these changes
Jun 3, 2024
* Introduces `pg_tde2` access method * New access method uses the event trigger changes from Percona-Lab#196 * Keys are now loaded from the keyring * This required changes to the map file / master key infrastructure * This commit only modifies/fixes those as little as required for simplicity. More refactoring/changes coming in separate commits / PRs * Removes reliance from MyDatabaseId, as things now have to work with multiple databases in the checkpointer * Removes some error reports, where functions should work even without a configured keyring * Fixes some bugs in the map file functions * Map file functions now work with multiple databases in a single process, but this is a hackish solution, global state needs a proper refactoring * Contains anti-recursion hack in the new SMGR code, which is needed until we store the metadata in the catalog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pg_tde2access methodMore refactoring/changes coming in separate commits / PRs