Code re-arrangement, Makefile fixes and implementing '.tde' relation fork #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixing the Makefile to link with ssl and crypto libs required by the extension. - An entry file pg_tde.c for all extension-related initialization functions - A a new ".tde" relation fork to store the encryption key and related data. Currently, the relation fork gets created with new relations and a dummy encryption key gets stored in the fork. - Re-arranging the directory structure to separate source and header files
dutow
reviewed
Aug 22, 2023
The function prototype was mistakenly left out in old header when it was moved to pg_tde_tdemap.
dAdAbird
reviewed
Aug 24, 2023
There was a problem hiding this comment.
Here https://github.com/Percona-Lab/postgres-tde-ext/pull/5/files#diff-30d8f6be6320feeacf686be94f48c70869b52630e01ea625f0f15adc0d57c3e4R17
should be
incdir = include_directories('src/include')
dutow
approved these changes
Aug 24, 2023
dAdAbird
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the Makefile to link with ssl and crypto libs required by the extension.
An entry file pg_tde.c for all extension-related initialization functions
A a new ".tde" relation fork to store the encryption key and related data. Currently, the relation fork gets created with new relations and a dummy encryption key gets stored in the fork.
Re-arranging the directory structure to separate source and header files