Minimal keyring prototype #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dutow
force-pushed
the
keyring
branch
2 times, most recently
from
af8523b
to
72bc641
Compare
dutow
force-pushed
the
keyring
branch
2 times, most recently
from
ccb0592
to
821a790
Compare
This commit implements a very basic file based keyring, intended for development.
To use the server after these changes, the following initialization steps are required:
* pg_tde should be preloaded: ALTER SYSTEM SET shared_preload_libraries = 'pg_tde';
* pg_tde extension should be installed
* pg_tde.keyringConfigFile = '<path>' should be set in postgresql.conf or command line
* The config file is a simple json file
* After the variable is set, and the config file exists, the server needs a restart
Example config file:
{
'provider': 'file',
'datafile': '/tmp/pgkeyring.data',
}
dAdAbird
reviewed
Aug 31, 2023
src/Makefile
Outdated
| @@ -0,0 +1,19 @@ | |||
| # contrib/pg_tde/Makefile | |||
There was a problem hiding this comment.
I don't think we need this file anymore. It was removed in 9fa73a6#diff-3e2513390df543315686d7c85bd901ca9256268970032298815d2f893a9f0685
dAdAbird
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements a very basic file based keyring, intended for development.
To use the server after these changes, the following initialization steps are required:
Example config file:
{
'provider': 'file',
'datafile': '/tmp/pgkeyring.data',
}