Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing adapting from Resource with no super type. #7

Merged
merged 1 commit into from Jan 22, 2019

Conversation

rbotha78
Copy link
Contributor

Discovered an issue with updateDataLayer method not being called on models that are adapting from Resource, if the resource super type is not set.

Checking if the parent resource type is null before trying to compare it with the grandparent resource type fixes the problem.

@klcodanr klcodanr merged commit bea2b07 into PerficientDigital:master Jan 22, 2019
@rbotha78 rbotha78 deleted the fix/resource_adaptable branch January 22, 2019 13:30
@klcodanr klcodanr added this to the 0.3.0 milestone Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants