fix: paused input design

This commit fixes the design of `paused` and its usage, now controlled mainly by enums. This addresses a serious issue that on "false" it would never put the paused into the JSON.
PerformanC · May 13, 2024 · f3b8cd5 · f3b8cd5
1 parent babaccb
commit f3b8cd5
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/include/rest.h b/include/rest.h
@@ -120,12 +120,17 @@ struct coglink_update_player_filters_params {
   struct coglink_update_player_filters_lowPass_params *lowPass;
 };
 
+enum coglink_paused_state {
+  COGLINK_PAUSED_STATE_FALSE = 1,
+  COGLINK_PAUSED_STATE_TRUE = 2
+};
+
 struct coglink_update_player_params {
   struct coglink_update_player_track_params *track;
   int position;
   int endTime;
   int volume;
-  bool paused;
+  enum coglink_paused_state paused;
   struct coglink_update_player_filters_params *filters;
 };
 

diff --git a/lib/rest.c b/lib/rest.c
@@ -383,9 +383,9 @@ int coglink_update_player(struct coglink_client *c_client, struct coglink_player
   if (params->track) {
     pjsonb_enter_object(&jsonber, "track");
 
-    if (params->track->encoded) pjsonb_set_string(&jsonber, "encoded", params->track->encoded);
-    if (params->track->identifier) pjsonb_set_string(&jsonber, "identifier", params->track->identifier);
-    if (params->track->userData) pjsonb_set_string(&jsonber, "userData", params->track->userData);
+    if (params->track->encoded != NULL) pjsonb_set_string(&jsonber, "encoded", params->track->encoded);
+    if (params->track->identifier != NULL) pjsonb_set_string(&jsonber, "identifier", params->track->identifier);
+    if (params->track->userData != NULL) pjsonb_set_string(&jsonber, "userData", params->track->userData);
 
     pjsonb_leave_object(&jsonber);
   }
@@ -403,7 +403,7 @@ int coglink_update_player(struct coglink_client *c_client, struct coglink_player
   }
 
   if (params->paused) {
-    pjsonb_set_bool(&jsonber, "paused", params->paused);
+    pjsonb_set_bool(&jsonber, "paused", params->paused == COGLINK_PAUSED_STATE_TRUE ? true : false);
   }
 
   if (params->filters) {