Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Missing Comments #24

Merged
merged 4 commits into from
Sep 10, 2023
Merged

Conversation

ctrl-escp
Copy link
Contributor

As reported in REstringer issue #87:
AST changes dropped all comments.
The expected behavior is to attach the comments to the replacement node, or the closest relevant node in case of deletion.

@BenBaryoPX BenBaryoPX self-requested a review September 10, 2023 11:04
@BenBaryoPX BenBaryoPX merged commit fc64a65 into PerimeterX:main Sep 10, 2023
2 checks passed
@ctrl-escp ctrl-escp deleted the fix/keep_comments branch September 10, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants