New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace [\da-f] with [[:xdigit:]] #100

Closed

wchristian opened this issue Nov 12, 2014 · 1 comment

Labels

bug

Milestone

Member

wchristian commented Nov 12, 2014

I believe \d can match non-arabic numerals too.

wchristian added the bug label

Collaborator

moregan commented Nov 19, 2014

$ ack -i a-f
lib/PPI/Token/Number/Hex.pm
79: if ( $char =~ /[\da-f]/i ) {

lib/PPI/Cache.pm
271:    return (defined $it and ! ref $it and $it =~ /^[a-f0-9]{32}\z/si)

t/19_selftesting.t
87: like( $md5a, qr/^[0-9a-f]{32}\z/, 'md5hex_file ok' );

Confirmed through perlbrew that [[:xdigit:]] exists in 5.6.2. xdigit includes both upper and lower case.

moregan added a commit to moregan/PPI that referenced this issue


          use xdigit character class -- fix Perl-Critic#100

wchristian closed this as completed in

a212df0

wchristian added this to the 1.222 milestone

moregan added a commit that referenced this issue


          use xdigit character class -- fix #100

e154971

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment