Add byte offsets for Tokens #186
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byte_span() allows to refer to specific ranges of source code within a document note that this works on Token level to allow referring to a specific token within an Element (e.g. PPI::Token::Word within PPI::Statement::Include) for every token we now store its starting byte position and ending byte is deduced as start byte + token byte length this works for all token types except HereDoc, which requires some extra bookkeeping see comments in lib/PPI/Token/HereDoc.pm for further details
wchristian
force-pushed
the
master
branch
4 times, most recently
from
07cd2bb
to
46e810f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a new method that returns positions of the first and the last bytes of a Token (byte span).
It comes in handy e.g. when building smart code viewer apps (
PPI::Element->location()is not precise enough) or working with code analysis libraries (all libraries I'm aware of require byte offsets).