#246 CHECK bareword handle parsed as scheduled block #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
followed by '{' or ';'. Otherwise it is not parsed as a scheduled block.
I have run both modified and unmodified PPI against all of CPAN, looking
for instances of PPI::Statement::Scheduled where the keyword is not
followed by a block. All the differences were either irrelevant (stuff
like temporary directory names, or non-Perl (i.e. filters)), or
statements like
open( CHECK, ... )
which disappeared when the new code was used.
|
Any chance of this being accepted? Or rejected? I submitted it back in February, and then completely forgot about it until I got my cage rattled on the original Perl::Critic issue, to wit [https://github.com/Perl-Critic/Perl-Critic/issues/878]. |
|
Sorry, i'll try and have a look tomorrow. :) |
|
Nudge? |
|
Closing and re-opening to trigger CI. |
|
This looks ok if the tests pass after rebasing. The stray newline can probably go? There should be an additional ticket to verify that this stuff behaves well for all of these: https://perldoc.perl.org/perlmod#BEGIN,-UNITCHECK,-CHECK,-INIT-and-END |
|
I have a rebased branch and will merge at the command line if the checks pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix ensures that a the keyword for a prospective scheduled block is followed by '{' or ';'. Otherwise it is not parsed as a scheduled block.
I have run both modified and unmodified PPI against all of CPAN, looking for instances of PPI::Statement::Scheduled where the keyword is not followed by a block. All the differences were either irrelevant (stuff like temporary directory names, or non-Perl (i.e. filters)), or
statements like
open( CHECK, ... )
which disappeared when the new code was used.