Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebase #254: Implement Replace Method #274

Closed
wants to merge 2 commits into from
Closed

Rebase #254: Implement Replace Method #274

wants to merge 2 commits into from

Conversation

oalders
Copy link
Collaborator

@oalders oalders commented Jul 13, 2022 •
edited

Closes #189

@oalders oalders marked this pull request as ready for review July 13, 2022 01:25
@oalders oalders closed this Jul 13, 2022
@oalders oalders reopened this Jul 13, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2022 •
edited

Codecov Report

Merging #274 (c01f4ec) into master (0ea5cb7) will increase coverage by 0.16%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master     #274      +/-   ##
==========================================
+ Coverage   79.03%   79.19%   +0.16%     
==========================================
  Files          92       92              
  Lines        3324     3331       +7     
  Branches      944      948       +4     
==========================================
+ Hits         2627     2638      +11     
+ Misses        380      370      -10     
- Partials      317      323       +6
Impacted Files Coverage Δ
lib/PPI/Element.pm 75.75% <50.00%> (+0.60%) ⬆️
lib/PPI/Node.pm 79.41% <80.00%> (+3.77%) ⬆️
lib/PPI/Token/Magic.pm 89.28% <0.00%> (-1.79%) ⬇️
lib/PPI/Token/Unknown.pm 91.91% <0.00%> (-1.52%) ⬇️
lib/PPI/Token/Word.pm 76.78% <0.00%> (ø)
lib/PPI/Token/Whitespace.pm 92.13% <0.00%> (+1.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ea5cb7...c01f4ec. Read the comment docs.

@oalders oalders force-pushed the rb_replace branch 2 times, most recently from fac08bc to a261914 Compare July 13, 2022 11:57
@oalders oalders requested a review from wchristian July 13, 2022 12:30
@oalders oalders mentioned this pull request Jul 13, 2022
Closed
wchristian
wchristian requested changes Jul 13, 2022
View reviewed changes
lib/PPI/Element.pm Outdated Show resolved Hide resolved
lib/PPI/Node.pm Outdated Show resolved Hide resolved
lib/PPI/Node.pm Outdated Show resolved Hide resolved
lib/PPI/Node.pm Outdated Show resolved Hide resolved
t/ppi_element_replace.t Outdated Show resolved Hide resolved
lib/PPI/Node.pm Outdated Show resolved Hide resolved
@wchristian
Copy link
Member

looks good to me :)

@oalders
Copy link
Collaborator Author

oalders commented Jul 19, 2022

Merged at the command line.

@oalders oalders closed this Jul 19, 2022
@oalders oalders deleted the rb_replace branch September 8, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reneeb reneeb reneeb left review comments

@wchristian wchristian wchristian requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

please implement "replace" method
4 participants
@oalders @codecov-commenter @wchristian @reneeb