RequireFinalReturn bug returning after whitespace-stripping here-doc ?

[trmz]

Not sure if bug.

If you return immediately after a whitespace-stripping here-doc, perlcritic warns about Subroutines::RequireFinalReturn, '[...] does not end with "return".'

Test module :

package Test;
use warnings;
use strict;

sub test {
    my $str = <<~'HEREDOC';
        some text
HEREDOC

    return $str;
}

1;

Test.pm: (Severity 4) Line 5: Subroutine "test" does not end with "return"

Doesn't seem to matter what you return.
Putting any code between the closing HEREDOC and the return causes issue to not occur.
Even (incorrectly) putting a semicolon after the closing HEREDOC appeases perlcritic, while also not compiling.

I would expect perlcritic to not complain.

Using Perl 5.26.1 and perlcritic 1.130.

[s-nez]

It's most likely caused by indented heredocs not being supported by PPI yet (Perl-Critic/PPI#203).

[ralesk]

They seem to be supported now and when updating both PPI and Critic to newest (1.270 and 1.134), fixed Critic complaining about things when it shouldn't (in my case it was the last sub in a module and it complained about the module not ending with 1; — but I tried to replicate OP's situation and it passed also).

[bokutin]

I encountered the same problem.

Reproduce if the following line is included in dist.ini.
[PkgVersion] or [PodWeaver]

Most Dist::Zilla users mean that the indented heredoc doesn't work as intended.