New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WriteMakefile() should warn more on invalid arguments #214
Comments
somewhat orthogonal note: there is some confusion about what the correct regex is for a valid package name; IMHO this should be a core API somewhere, but whatever we use in EUMM, we can easily refine it later. Even just |
For comparison:
|
for EUMM this isn't good because MR isn't a core module and this regex isn't correct (it is far too restrictive; see also recent discussions in Sub::Name's queues, and I'm also amassing lots of notes in this space), but it's fine for gtodd's cleanup purposes. |
++ I think I may have been hinting that some of the simple functions for interrogating/inspecting and modules in |
It's worth distinguishing between package names and module names (something that maps to a file). Package names can include unicode just fine, but for module names, the regex used by Module::Runtime is pretty reasonable, since handling unicode filenames portably is very tricky. |
e.g. the NAME field should be a module name, so we should warn when passed something that doesn't look like a module (e.g. contains a
-
)examples of distributions passing an invalid NAME: http://grep.cpan.me/?q=file%3AMakefile.PL+%28^|%5B^\w%5D%29NAME\s*%3D%3E.*\w-\w
The text was updated successfully, but these errors were encountered: