Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PERMS options to create temp file with given file permissions #30

Merged
merged 1 commit into from
Sep 1, 2019

Conversation

timgimyee
Copy link
Contributor

@timgimyee timgimyee commented Oct 25, 2018

Fixes #15.

@karenetheridge
Copy link
Member

see reservations from the author at https://rt.cpan.org/Ticket/Display.html?id=82516

@timgimyee
Copy link
Contributor Author

The author suggests that limiting to only overridden temp directories might be okay. So check for DIR option and that it isn't the default temp directory.

The PERMS option could also warn when used.

Any other ideas to keep the temp files safe? Or at least safer than the chmod work-around:

my ($fh, $tempfile) = tempfile();
chmod 0666, $tempfile or die $!;

@mohawk2
Copy link
Member

mohawk2 commented Aug 31, 2019

@xdg Would timgimyee's point be acceptable to you?

@xdg
Copy link
Contributor

xdg commented Sep 1, 2019

No strong feelings. If users want control over PERMS, that seems fine with me, with or without DIR.

@mohawk2 mohawk2 merged commit 186caee into Perl-Toolchain-Gang:master Sep 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to set permissions mode [rt.cpan.org #82516]
4 participants