Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix package_version_from_directory breakage with absolute file on win32 #24

Merged
merged 2 commits into from Jul 19, 2018

Conversation

Projects
None yet
2 participants
@wchristian
Copy link
Member

commented Sep 13, 2016

As discussed on IRC this PR contains a fix with test for absolute file paths being given to package_version_from_directory.

It also contains a related fix, which still needs test as per #23.

@wchristian

This comment has been minimized.

Copy link
Member Author

commented Sep 13, 2016

When this is released https://github.com/rwstauner/Dist-Metadata should be poked to bump requirement versions.

wchristian added some commits Sep 13, 2016

fix path splitting in package_versions_from_directory
I don't have a test for this because it would be a little more effort
than i want to give at the moment. The github issue #23 contains
information on how the test needs to be.

@wchristian wchristian force-pushed the wchristian:win32 branch from a5bce64 to dc1278c Jul 19, 2018

@karenetheridge karenetheridge merged commit 3068fb3 into Perl-Toolchain-Gang:master Jul 19, 2018

@karenetheridge

This comment has been minimized.

Copy link
Member

commented Jul 19, 2018

sorry for the delay! I will ship this as a -TRIAL release today.

@wchristian

This comment has been minimized.

Copy link
Member Author

commented Jul 19, 2018

Can you reopen this so it doesn't get lost that dist-metadata needs to be poked?

@karenetheridge

This comment has been minimized.

Copy link
Member

commented Jul 20, 2018

It doesn't look like it can be reopened :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.