fix package_version_from_directory breakage with absolute file on win32 #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When this is released https://github.com/rwstauner/Dist-Metadata should be poked to bump requirement versions. |
I don't have a test for this because it would be a little more effort than i want to give at the moment. The github issue Perl-Toolchain-Gang#23 contains information on how the test needs to be.
|
sorry for the delay! I will ship this as a -TRIAL release today. |
|
Can you reopen this so it doesn't get lost that dist-metadata needs to be poked? |
|
It doesn't look like it can be reopened :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on IRC this PR contains a fix with test for absolute file paths being given to package_version_from_directory.
It also contains a related fix, which still needs test as per #23.