Skip to content

Commit

Permalink
Porting/core-cpan-diff: Remove '--binary'
Browse files Browse the repository at this point in the history
Other things being equal, this program defaults to passing '-u --binary'
to the 'diff' command.  But there is no such option to 'diff' on either
Linux or FreeBSD.  Consequently, running the program spews more than
80,000 lines of error output.  Removing that option from code and
documentation makes the program DWIM.
  • Loading branch information
jkeenan committed Aug 5, 2021
1 parent e9766ce commit 0a8368f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Porting/core-cpan-diff
Expand Up @@ -53,7 +53,7 @@ Usage: $0 [opts] [ -d | -v | -x ] [ -a | module ... ]
-d/--diff Display file differences using diff(1), rather than just
listing which files have changed.
--diffopts Options to pass to the diff command. Defaults to '-u --binary'.
--diffopts Options to pass to the diff command. Defaults to '-u'.
-f|force Force download from CPAN of new 02packages.details.txt file
(with --crosscheck only).
Expand Down Expand Up @@ -125,7 +125,7 @@ sub run {
if ( $reverse || $use_diff || $diff_opts );
}
else {
$diff_opts = '-u --binary' unless defined $diff_opts;
$diff_opts = '-u' unless defined $diff_opts;
usage("can't use -f without --crosscheck") if $force;
}

Expand Down

0 comments on commit 0a8368f

Please sign in to comment.