PerlIO::encoding: explicitly cast char * to STDCHAR *

This should avoid the "pointer targets in assignment differ in signedness" warning that pops up in some configurations.
Perl · Jan 31, 2016 · 0bca550 · 0bca550
1 parent 259f5e0
commit 0bca550
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/ext/PerlIO-encoding/encoding.pm b/ext/PerlIO-encoding/encoding.pm
@@ -1,7 +1,7 @@
 package PerlIO::encoding;
 
 use strict;
-our $VERSION = '0.23';
+our $VERSION = '0.24';
 our $DEBUG = 0;
 $DEBUG and warn __PACKAGE__, " called by ", join(", ", caller), "\n";
 

diff --git a/ext/PerlIO-encoding/encoding.xs b/ext/PerlIO-encoding/encoding.xs
@@ -462,8 +462,8 @@ PerlIOEncode_flush(pTHX_ PerlIO * f)
 	    if (!SvPOKp(e->bufsv) || SvTHINKFIRST(e->bufsv))
 		(void)SvPV_force_nolen(e->bufsv);
 	    if ((STDCHAR *)SvPVX(e->bufsv) != e->base.buf) {
-		e->base.ptr = SvEND(e->bufsv);
-		e->base.end = SvPVX(e->bufsv) + (e->base.end-e->base.buf);
+		e->base.ptr = (STDCHAR *)SvEND(e->bufsv);
+		e->base.end = (STDCHAR *)SvPVX(e->bufsv) + (e->base.end-e->base.buf);
 		e->base.buf = (STDCHAR *)SvPVX(e->bufsv);
 	    }
 	    (void)PerlIOEncode_get_base(aTHX_ f);