lseek fd can be bad.

Coverity CID 104788
Perl · Jun 27, 2015 · 511343a · 511343a
1 parent b66176f
commit 511343a
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/ext/POSIX/POSIX.xs b/ext/POSIX/POSIX.xs
@@ -3210,9 +3210,14 @@ lseek(fd, offset, whence)
 	Off_t		offset
 	int		whence
     CODE:
-	Off_t pos = PerlLIO_lseek(fd, offset, whence);
-	RETVAL = sizeof(Off_t) > sizeof(IV)
-		 ? newSVnv((NV)pos) : newSViv((IV)pos);
+	if (fd >= 0) {
+            Off_t pos = PerlLIO_lseek(fd, offset, whence);
+            RETVAL = sizeof(Off_t) > sizeof(IV)
+              ? newSVnv((NV)pos) : newSViv((IV)pos);
+        } else {
+            SETERRNO(EBADF,RMS_IFI);
+            RETVAL = newSViv(-1);
+        }
     OUTPUT:
 	RETVAL