Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert "regcomp.c: Add shortcuts to some inversion list ops"
This reverts commit c29dfc6. But it also removes the XXX suggesting that the things that commit did should be done. It turns out that I didn't fully understand this, that the shortcuts weren't found as frequently as I expected, and in fact happened when they shouldn't have, creating bugs. The only bugs I found had to do with displaying what the regex compiled into under -Dr, but I imagine there are others out there. I did try to create some test cases that showed the bugs, based on understanding how the code works, but various things prevented them from actually being bugs. To correctly decide to take the shortcut requires adding tests inside a loop, and the shortcut is just to possibly save some work after the loop. That isn't a good tradeoff.
- Loading branch information
1 parent
e171168
commit 51e3e8c
Showing
1 changed file
with
37 additions
and
105 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters