Skip to content

Commit

Permalink
PATCH: [perl #122126] BBC DBD::SQLite
Browse files Browse the repository at this point in the history
This problem turns out to be a misspelling in two places of a compiler
definition.  Since the definition didn't exist (as it was misspelled),
the #ifdef failed.

I don't know how really to test this as it is locale collation, which
varies by locale, and we would be relying on vendor-supplied locales
which may be inconsistent between platforms.  I intend to tackle
improvements to collaction later this release cycle, and should come up
with tests at that time.  The failing tests in the module were comparing
the Perl sort results with those of the module, and finding they differ.
  • Loading branch information
khwilliamson committed Jun 18, 2014
1 parent 4b2fb10 commit 5778acb
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pp.c
Expand Up @@ -2138,7 +2138,7 @@ PP(pp_sle)
{
dPOPTOPssrl;
const int cmp =
#ifdef USE_LC_COLLATE
#ifdef USE_LOCALE_COLLATE
(IN_LC_RUNTIME(LC_COLLATE))
? sv_cmp_locale_flags(left, right, 0)
:
Expand Down Expand Up @@ -2178,7 +2178,7 @@ PP(pp_scmp)
{
dPOPTOPssrl;
const int cmp =
#ifdef USE_LC_COLLATE
#ifdef USE_LOCALE_COLLATE
(IN_LC_RUNTIME(LC_COLLATE))
? sv_cmp_locale_flags(left, right, 0)
:
Expand Down

0 comments on commit 5778acb

Please sign in to comment.