Skip to content

Commit

Permalink
op.c: CHANGE_TYPE in Perl_ck_rvconst
Browse files Browse the repository at this point in the history
Here, op_type and op_ppaddr inits were separated by many lines.
Move them together, then replace with CHANGE_TYPE call.

--
v2- actually remove the explicit op_ppaddr assignment.
  • Loading branch information
jimc authored and Father Chrysostomos committed Nov 4, 2014
1 parent dc0c4db commit 72e8a95
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions op.c
Expand Up @@ -9459,7 +9459,7 @@ Perl_ck_rvconst(pTHX_ OP *o)
&& SvTYPE(SvRV(gv)) != SVt_PVCV)
gv_fetchsv(kidsv, GV_ADDMULTI, SVt_PVCV);
}
kid->op_type = OP_GV;
CHANGE_TYPE(kid, OP_GV);
SvREFCNT_dec(kid->op_sv);
#ifdef USE_ITHREADS
/* XXX hack: dependence on sizeof(PADOP) <= sizeof(SVOP) */
Expand All @@ -9471,7 +9471,6 @@ Perl_ck_rvconst(pTHX_ OP *o)
kid->op_sv = SvREFCNT_inc_simple_NN(gv);
#endif
kid->op_private = 0;
kid->op_ppaddr = PL_ppaddr[OP_GV];
/* FAKE globs in the symbol table cause weird bugs (#77810) */
SvFAKE_off(gv);
}
Expand Down

0 comments on commit 72e8a95

Please sign in to comment.