Skip to content

Commit

Permalink
mv function from locale.c to mathoms.c
Browse files Browse the repository at this point in the history
The previous commit causes this function being moved to be just a
wrapper not called in core.  Just in case someone is calling it, it is
retained, but moved to mathoms.c
  • Loading branch information
khwilliamson committed May 24, 2016
1 parent a4a439f commit 78d5797
Show file tree
Hide file tree
Showing 5 changed files with 20 additions and 16 deletions.
4 changes: 2 additions & 2 deletions embed.fnc
Expand Up @@ -908,9 +908,9 @@ pod |SV* |magic_methcall |NN SV *sv|NN const MAGIC *mg \
Ap |I32 * |markstack_grow
#if defined(USE_LOCALE_COLLATE)
p |int |magic_setcollxfrm|NN SV* sv|NN MAGIC* mg
pb |char* |mem_collxfrm |NN const char* input_string|STRLEN len|NN STRLEN* xlen
: Defined in locale.c, used only in sv.c
p |char* |mem_collxfrm |NN const char* input_string|STRLEN len|NN STRLEN* xlen
# if defined(PERL_IN_LOCALE_C) || defined(PERL_IN_SV_C)
# if defined(PERL_IN_LOCALE_C) || defined(PERL_IN_SV_C) || defined(PERL_IN_MATHOMS_C)
pM |char* |_mem_collxfrm |NN const char* input_string \
|STRLEN len \
|NN STRLEN* xlen \
Expand Down
4 changes: 3 additions & 1 deletion embed.h
Expand Up @@ -1559,7 +1559,7 @@
#define share_hek_flags(a,b,c,d) S_share_hek_flags(aTHX_ a,b,c,d)
#define unshare_hek_or_pvn(a,b,c,d) S_unshare_hek_or_pvn(aTHX_ a,b,c,d)
# endif
# if defined(PERL_IN_LOCALE_C) || defined(PERL_IN_SV_C)
# if defined(PERL_IN_LOCALE_C) || defined(PERL_IN_SV_C) || defined(PERL_IN_MATHOMS_C)
# if defined(USE_LOCALE_COLLATE)
#define _mem_collxfrm(a,b,c,d) Perl__mem_collxfrm(aTHX_ a,b,c,d)
# endif
Expand Down Expand Up @@ -1849,7 +1849,9 @@
# endif
# if defined(USE_LOCALE_COLLATE)
#define magic_setcollxfrm(a,b) Perl_magic_setcollxfrm(aTHX_ a,b)
#ifndef NO_MATHOMS
#define mem_collxfrm(a,b,c) Perl_mem_collxfrm(aTHX_ a,b,c)
#endif
# endif
# if defined(USE_PERLIO)
#define PerlIO_restore_errno(a) Perl_PerlIO_restore_errno(aTHX_ a)
Expand Down
12 changes: 0 additions & 12 deletions locale.c
Expand Up @@ -1373,20 +1373,8 @@ Perl_init_i18nl10n(pTHX_ int printwarn)
return ok;
}


#ifdef USE_LOCALE_COLLATE

char *
Perl_mem_collxfrm(pTHX_ const char *input_string, STRLEN len, STRLEN *xlen)
{
/* This function is retained for compatibility in case someone outside core
* is using this (but it is undocumented) */

PERL_ARGS_ASSERT_MEM_COLLXFRM;

return _mem_collxfrm(input_string, len, xlen, FALSE);
}

char *
Perl__mem_collxfrm(pTHX_ const char *input_string,
STRLEN len, /* Length of 'input_string' */
Expand Down
12 changes: 12 additions & 0 deletions mathoms.c
Expand Up @@ -1096,6 +1096,18 @@ Perl_sv_collxfrm(pTHX_ SV *const sv, STRLEN *const nxp)
{
return sv_collxfrm_flags(sv, nxp, SV_GMAGIC);
}

char *
Perl_mem_collxfrm(pTHX_ const char *input_string, STRLEN len, STRLEN *xlen)
{
/* This function is retained for compatibility in case someone outside core
* is using this (but it is undocumented) */

PERL_ARGS_ASSERT_MEM_COLLXFRM;

return _mem_collxfrm(input_string, len, xlen, FALSE);
}

#endif

bool
Expand Down
4 changes: 3 additions & 1 deletion proto.h
Expand Up @@ -4430,7 +4430,7 @@ PERL_CALLCONV SV* Perl_hfree_next_entry(pTHX_ HV *hv, STRLEN *indexp);
#define PERL_ARGS_ASSERT_HFREE_NEXT_ENTRY \
assert(hv); assert(indexp)
#endif
#if defined(PERL_IN_LOCALE_C) || defined(PERL_IN_SV_C)
#if defined(PERL_IN_LOCALE_C) || defined(PERL_IN_SV_C) || defined(PERL_IN_MATHOMS_C)
# if defined(USE_LOCALE_COLLATE)
PERL_CALLCONV char* Perl__mem_collxfrm(pTHX_ const char* input_string, STRLEN len, STRLEN* xlen, bool utf8);
#define PERL_ARGS_ASSERT__MEM_COLLXFRM \
Expand Down Expand Up @@ -5792,9 +5792,11 @@ STATIC char* S_stdize_locale(pTHX_ char* locs);
PERL_CALLCONV int Perl_magic_setcollxfrm(pTHX_ SV* sv, MAGIC* mg);
#define PERL_ARGS_ASSERT_MAGIC_SETCOLLXFRM \
assert(sv); assert(mg)
#ifndef NO_MATHOMS
PERL_CALLCONV char* Perl_mem_collxfrm(pTHX_ const char* input_string, STRLEN len, STRLEN* xlen);
#define PERL_ARGS_ASSERT_MEM_COLLXFRM \
assert(input_string); assert(xlen)
#endif
/* PERL_CALLCONV char* sv_collxfrm(pTHX_ SV *const sv, STRLEN *const nxp); */
PERL_CALLCONV char* Perl_sv_collxfrm_flags(pTHX_ SV *const sv, STRLEN *const nxp, I32 const flags);
#define PERL_ARGS_ASSERT_SV_COLLXFRM_FLAGS \
Expand Down

0 comments on commit 78d5797

Please sign in to comment.