Skip to content

Commit

Permalink
Change Gconvert checkit() prototype for [perl #134371].
Browse files Browse the repository at this point in the history
In the checkit() routine inside Configure, clang++ was taking the
if (strcmp(expect, got)) branch even though the 'expect' and 'got' strings
were identical.  A first step in debugging this was to realize that
the checkit() function never returned a value, so relabel it as void.
With clang version 7.0.1-8 (tags/RELEASE_701/final) (Debian),
this change seems to work around the strcmp issue.
  • Loading branch information
doughera88 committed Aug 19, 2019
1 parent 74cd64c commit a9425c4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Configure
Original file line number Diff line number Diff line change
Expand Up @@ -10426,7 +10426,7 @@ char *myname = "sprintf";
#endif
#include <string.h>

int checkit(char *expect, char *got)
void checkit(char *expect, char *got)
{
if (strcmp(expect, got)) {
printf("%s oddity: Expected %s, got %s\n",
Expand Down

0 comments on commit a9425c4

Please sign in to comment.