Skip to content

Commit

Permalink
DynaLoader: dl_dyld.xs: don't undef bool
Browse files Browse the repository at this point in the history
I expect this was added when we added our own bool, and before
we used bool so liberally ourselves.  Now dl_dyld.xs fails to
compile, since MY_CXT_CLONE indirectly uses UNLIKELY() which
casts to bool.

Tested locally with:

  ./Configure -des -Dusedevel -Dusethreads -Ddlsrc=dl_dyld.xs

on a modern Darwin, which failed before this change and builds
after.

Based on work done by Sevan Janiyan in #21751.

Fixes #21751
  • Loading branch information
tonycoz committed Feb 28, 2024
1 parent babcc2d commit d3f42b8
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion ext/DynaLoader/dl_dyld.xs
Expand Up @@ -48,7 +48,6 @@ been tested on NeXT platforms.
#include "dlutils.c" /* for SaveError() etc */

#undef environ
#undef bool
#import <mach-o/dyld.h>

static char *dlerror()
Expand Down

0 comments on commit d3f42b8

Please sign in to comment.