Skip to content

Commit

Permalink
Revert "Temporarily revert CV-in-stash optimisation"
Browse files Browse the repository at this point in the history
This reverts commit 6eed25e.
  • Loading branch information
Father Chrysostomos committed Nov 11, 2017
1 parent 445198b commit d964025
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion op.c
Expand Up @@ -9617,7 +9617,7 @@ Perl_newATTRSUB_x(pTHX_ I32 floor, OP *o, OP *proto, OP *attrs,
sub is stored in. */
const I32 flags =
ec ? GV_NOADD_NOINIT
: PL_curstash != CopSTASH(PL_curcop)
: (IN_PERL_RUNTIME && PL_curstash != CopSTASH(PL_curcop))
|| memchr(name, ':', namlen) || memchr(name, '\'', namlen)
? gv_fetch_flags
: GV_ADDMULTI | GV_NOINIT | GV_NOTQUAL;
Expand Down
1 change: 0 additions & 1 deletion t/op/sub.t
Expand Up @@ -423,7 +423,6 @@ is ref($main::{rt_129916}), 'CODE', 'simple sub stored as CV in stash (main::)';
sub foo { 42 }
}
{
local $TODO = "CV symbol table optimization only works in main:: [perl #129916]";
is ref($RT129916::{foo}), 'CODE', 'simple sub stored as CV in stash (non-main::)';
}

Expand Down

0 comments on commit d964025

Please sign in to comment.