Skip to content

Commit

Permalink
[perl #92906] perl -d has non-functional b command
Browse files Browse the repository at this point in the history
This fixes a regression introduced after 5.14.0.

Commit 6f83ef0 got dbfile and dbline magic mixed up and ended up
apply set-magic to the hash (dbfile), not to the element (dbline).

The result was that debugger breakpoints simply did not work at all.
  • Loading branch information
Father Chrysostomos committed Jun 16, 2011
1 parent eb883b9 commit f34d156
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
4 changes: 2 additions & 2 deletions mg_raw.h
Expand Up @@ -50,9 +50,9 @@
"/* isaelem 'i' @ISA array element */" },
{ 'k', "want_vtbl_nkeys | PERL_MAGIC_VALUE_MAGIC",
"/* nkeys 'k' scalar(keys()) lvalue */" },
{ 'L', "want_vtbl_dbline",
{ 'L', "magic_vtable_max",
"/* dbfile 'L' Debugger %_<filename */" },
{ 'l', "magic_vtable_max",
{ 'l', "want_vtbl_dbline",
"/* dbline 'l' Debugger %_<filename element */" },
{ 'o', "want_vtbl_collxfrm | PERL_MAGIC_VALUE_MAGIC",
"/* collxfrm 'o' Locale transformation */" },
Expand Down
5 changes: 3 additions & 2 deletions regen/mg_vtable.pl
Expand Up @@ -53,9 +53,10 @@ BEGIN
desc => '@ISA array element' },
nkeys => { char => 'k', vtable => 'nkeys', value_magic => 1,
desc => 'scalar(keys()) lvalue' },
dbfile => { char => 'L', vtable => 'dbline',
dbfile => { char => 'L',
desc => 'Debugger %_<filename' },
dbline => { char => 'l', desc => 'Debugger %_<filename element' },
dbline => { char => 'l', vtable => 'dbline',
desc => 'Debugger %_<filename element' },
shared => { char => 'N', desc => 'Shared between threads',
unknown_to_sv_magic => 1 },
shared_scalar => { char => 'n', desc => 'Shared between threads',
Expand Down

0 comments on commit f34d156

Please sign in to comment.