-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sprintf ignores LC_NUMERIC when folding constants #10769
Comments
From @ntyniThis is a bug report for perl from Niko Tyni <ntyni@debian.org>, Commit c427f4d in 5.10.1 made sprintf() perl -Mlocale -MPOSIX=locale_h -e 'setlocale(LC_NUMERIC, "fi_FI") or die; printf("%s should be %g\n", sprintf("%g", 2.4), 2.4)' (At least de_DE and sv_SE should also do for the locale.) The bug is with constant folding, this works: perl -Mlocale -MPOSIX=locale_h -e 'setlocale(LC_NUMERIC, "fi_FI") or die; $in = 2.4; printf("%s should be %g\n", sprintf("%g", $in), 2.4)' Proposed patch attached, including a regression test. The test requires Flags: Site configuration information for perl 5.13.6: Configured by niko at Tue Oct 26 23:55:38 EEST 2010. Summary of my perl5 (revision 5 version 13 subversion 6) configuration: Locally applied patches: @INC for perl 5.13.6: Environment for perl 5.13.6: |
From @ntyni0001-Don-t-fold-constants-in-sprintf-if-locales-are-used.patchFrom 7e37740c88629b397d90d5fbf7e8b2a66fe1bc16 Mon Sep 17 00:00:00 2001
From: Niko Tyni <ntyni@debian.org>
Date: Wed, 27 Oct 2010 10:56:24 +0300
Subject: [PATCH] Don't fold constants in sprintf() if locales are used
Commit c427f4d2d4575fbc8a5190932fe321136c7597b3 in 5.10.1 made sprintf()
ignore LC_NUMERIC for numeric constants.
---
op.c | 1 +
t/run/locale.t | 15 ++++++++++++++-
2 files changed, 15 insertions(+), 1 deletions(-)
diff --git a/op.c b/op.c
index cfa9d6b..615678e 100644
--- a/op.c
+++ b/op.c
@@ -2588,6 +2588,7 @@ S_fold_constants(pTHX_ register OP *o)
case OP_SLE:
case OP_SGE:
case OP_SCMP:
+ case OP_SPRINTF:
/* XXX what about the numeric ops? */
if (PL_hints & HINT_LOCALE)
goto nope;
diff --git a/t/run/locale.t b/t/run/locale.t
index 483123f..2f7306b 100644
--- a/t/run/locale.t
+++ b/t/run/locale.t
@@ -128,6 +128,19 @@ EOF
"too late to ignore the locale at write() time");
}
}
+
+ for ($different) {
+ local $ENV{LC_NUMERIC} = $_;
+ local $ENV{LC_ALL}; # so it never overrides LC_NUMERIC
+ fresh_perl_is(<<'EOF', "$difference "x4, {},
+ use locale;
+ use POSIX qw(locale_h);
+ setlocale(LC_NUMERIC, "");
+ my $in = 4.2;
+ printf("%g %g %s %s ", $in, 4.2, sprintf("%g", $in), sprintf("%g", 4.2));
+EOF
+ "sprintf() and printf() look at LC_NUMERIC regardless of constant folding");
+ }
} # SKIP
-sub last { 6 }
+sub last { 7 }
--
1.7.2.3
|
From @cpansproutOn Wed Oct 27 01:14:11 2010, ntyni@debian.org wrote:
Thank you. Applied as b3fd614. |
The RT System itself - Status changed from 'new' to 'open' |
@cpansprout - Status changed from 'open' to 'resolved' |
Migrated from rt.perl.org#78632 (status was 'resolved')
Searchable as RT78632$
The text was updated successfully, but these errors were encountered: