Update perlhack.pod - fix link to mirror git repo #1

MartinMcGrath · 2013-12-18T14:28:09Z

Change dead link http://github.com/mirrors/perl to https://github.com/Perl/perl5

to avoid splain output like this on 80-column terminals: rewinddir() attempted on invalid dirhandle foo at -e line 1 (#1) (W io) The dirhandle you tried to do a rewinddir() on is either closed or no t really a dirhandle. Check your control flow.

to the other part of the message. diagnostics.pm won’t find it otherwise: $ perl -Mdiagnostics -we '"foo"->bar' Can't locate object method "bar" via package "foo" (perhaps you forgot to load "foo"?) at -e line 1 (#1) Uncaught exception from user code: Can't locate object method "bar" via package "foo" (perhaps you forgot to load "foo"?) at -e line 1. Now we have this: Can't locate object method "bar" via package "foo" (perhaps you forgot to load "foo"?) at -e line 1 (#1) (F) You called a method on a class that did not exist, and the method could not be found in UNIVERSAL. This often means that a method requires a package that has not been loaded. Uncaught exception from user code: Can't locate object method "bar" via package "foo" (perhaps you forgot to load "foo"?) at -e line 1.

In the op tree, a statement consists of a nextstate/dbstate op (of class cop) followed by the contents of the statement. This cop is created after the statement has been parsed. So if you have nested statements, the outermost statement has the highest sequence number (cop_seq). Every sub (including BEGIN blocks) has a sequence number indicating where it occurs in its containing sub. So BEGIN { } #1 # seq 2 { # seq 1 ... } is indistinguishable from # seq 2 { BEGIN { } #1 # seq 1 ... } because the sequence number of the BEGIN block is 1 in both examples. By reserving a sequence number at the start of every block and using it once the block has finished parsing, we can do this: BEGIN { } #1 # seq 1 { # seq 2 ... } # seq 1 { BEGIN { } #2 # seq 2 ... } and now B::Deparse can tell where to put the blocks. PL_compiling.cop_seq was unused, so this is where I am stashing the pending sequence number.

$#1 is a syntax error.

to the other part of the message. diagnostics.pm wonâ€™t find it otherwise: $ perl -Mdiagnostics -we '"foo"->bar' Can't locate object method "bar" via package "foo" (perhaps you forgot to load "foo"?) at -e line 1 (#1) Uncaught exception from user code: Can't locate object method "bar" via package "foo" (perhaps you forgot to load "foo"?) at -e line 1. Now we have this: Can't locate object method "bar" via package "foo" (perhaps you forgot to load "foo"?) at -e line 1 (#1) (F) You called a method on a class that did not exist, and the method could not be found in UNIVERSAL. This often means that a method requires a package that has not been loaded. Uncaught exception from user code: Can't locate object method "bar" via package "foo" (perhaps you forgot to load "foo"?) at -e line 1. (cherry picked from commit 8af56b9)

8c2e27d changed B::Deparse to deparse $#{1} as that instead of as $#1 which is a syntax error, but also changed $#_ to deparse as $#{_} which isn't necessary, and broke GFUJI/macro-0.06.tar.gz This could be considered a bug in macro.pm, but since we don't need to deparse $#_ as $#{_} let's not do that.

Coverity CID 135025 (#1 of 1): Out-of-bounds read (OVERRUN) 29. overrun-local: Overrunning array addr.sun_path of 108 bytes at byte offset 108 using index addr_len (which evaluates to 108). 864 for (addr_len = 0; addr.sun_path[addr_len] 28. incr: Incrementing addr_len. The value of addr_len may now be up to 108. 865 && addr_len < maxlen; addr_len++); Reported upstream as https://rt.cpan.org/Ticket/Display.html?id=111707

Coverity CID 135025 (Perl#1 of 1): Out-of-bounds read (OVERRUN) 29. overrun-local: Overrunning array addr.sun_path of 108 bytes at byte offset 108 using index addr_len (which evaluates to 108). 864 for (addr_len = 0; addr.sun_path[addr_len] 28. incr: Incrementing addr_len. The value of addr_len may now be up to 108. 865 && addr_len < maxlen; addr_len++); Reported upstream as https://rt.cpan.org/Ticket/Display.html?id=111707

In an eighty-column terminal, this is what it looked like before this commit: $ ./perl -Ilib -Mdiagnostics -E 'state ($x)=1' Initialization of state variables in list context currently forbidden at -e line 1, at EOF Execution of -e aborted due to compilation errors (#1) (F) state only permits initializing a single scalar variable, in scalar context. So state $a = 42 is allowed, but not state ($a) = 42. To apply state semantics to a hash or array, store a hash or array reference in a sca lar variable.

Switch from «use vars» to «our» or «my»

1.41 2024-08-25 22:32:19Z - fix leaks in @thread_object_registry (RT#64025, tusooa, #1 and Lukas Mai, #2) - fix incompatibility with Scalar::Util 1.65 and remove old refaddr fallback (Lukas Mai, #3)

1.41 2024-08-25 22:32:19Z - fix leaks in @thread_object_registry (RT#64025, tusooa, Perl#1 and Lukas Mai, Perl#2) - fix incompatibility with Scalar::Util 1.65 and remove old refaddr fallback (Lukas Mai, Perl#3)

This is #1 of a small series of commits to refactor the INPUT_handler() method and turn it into a Node subclass method. This commit changes the main loop from using $_ to hold the current line, to using the variable $line instead.

This is #1 of a small series of commits to refactor the OUTPUT_handler() method and turn it into a Node subclass method. This series is very similar to the one earlier in this branch which did the same for INPUT_handler(). This commit changes the main loop from using $_ to hold the current line, to using the variable $line instead.

This is #1 of a small series of commits to refactor the INPUT_handler() method and turn it into a Node subclass method. This commit changes the main loop from using $_ to hold the current line, to using the variable $line instead.

This is #1 of a small series of commits to refactor the OUTPUT_handler() method and turn it into a Node subclass method. This series is very similar to the one earlier in this branch which did the same for INPUT_handler(). This commit changes the main loop from using $_ to hold the current line, to using the variable $line instead.

This is #1 of a small series of commits to refactor the INPUT_handler() method and turn it into a Node subclass method. This commit changes the main loop from using $_ to hold the current line, to using the variable $line instead.

This is #1 of a small series of commits to refactor the OUTPUT_handler() method and turn it into a Node subclass method. This series is very similar to the one earlier in this branch which did the same for INPUT_handler(). This commit changes the main loop from using $_ to hold the current line, to using the variable $line instead.

Fixes a Coverity issue: >>> function_return: Function Perl_delimcpy_no_escape(tmpbuf, tmpbuf + 4096UL, s, bufend, 58, &len) modifies its argument, assigning 2147483647 to len. 3553 s = delimcpy_no_escape(tmpbuf, tmpbuf + sizeof tmpbuf, s, bufend, 3554 ':', &len); >>> CID 583353: (Perl#1 of 1): Overflowed constant (INTEGER_OVERFLOW) >>> overflow_const: Expression len + 1, where len is known to be equal to 2147483647, overflows the type of len + 1, which is type int. 3558 if (len + 1 + strlen(scriptname) + MAX_EXT_LEN >= sizeof tmpbuf) 3559 continue; /* don't search dir with too-long name */ If there is not enough available space in tmpbuf, delimcpy_no_escape sets len to I32_MAX, but the following code does not check for this. (I believe this case is reachable simply by setting PATH to a huge string.) Avoid the potential overflow by rewriting A + B >= C as A >= C - B (Also, make 'len' unsigned (specifically, size_t) to match the type of sizeof/strlen() and avoid warnings about comparisons between signed and unsigned integers.)

Fixes a Coverity issue: >>> function_return: Function Perl_delimcpy_no_escape(tmpbuf, tmpbuf + 4096UL, s, bufend, 58, &len) modifies its argument, assigning 2147483647 to len. 3553 s = delimcpy_no_escape(tmpbuf, tmpbuf + sizeof tmpbuf, s, bufend, 3554 ':', &len); >>> CID 583353: (#1 of 1): Overflowed constant (INTEGER_OVERFLOW) >>> overflow_const: Expression len + 1, where len is known to be equal to 2147483647, overflows the type of len + 1, which is type int. 3558 if (len + 1 + strlen(scriptname) + MAX_EXT_LEN >= sizeof tmpbuf) 3559 continue; /* don't search dir with too-long name */ If there is not enough available space in tmpbuf, delimcpy_no_escape sets len to I32_MAX, but the following code does not check for this. (I believe this case is reachable simply by setting PATH to a huge string.) Avoid the potential overflow by rewriting A + B >= C as A >= C - B (Also, make 'len' unsigned (specifically, size_t) to match the type of sizeof/strlen() and avoid warnings about comparisons between signed and unsigned integers.)

Update perlhack.pod - fix link to mirror git repo

d1b2ed9

Change dead link http://github.com/mirrors/perl to https://github.com/Perl/perl5

MartinMcGrath closed this Dec 18, 2013

p5p pushed a commit that referenced this pull request Dec 13, 2014

Deparse $#{1} with braces

8c2e27d

$#1 is a syntax error.

demerphq added a commit that referenced this pull request Feb 8, 2023

WS Cleanup Stage #1 - simple ws fixups

20c85b1

demerphq added a commit that referenced this pull request Feb 19, 2023

WS Cleanup Stage #1 - simple ws fixups

3f4a84b

demerphq added a commit that referenced this pull request Feb 20, 2023

WS Cleanup Stage #1 - simple ws fixups

ecb3ca4

tonycoz mentioned this pull request Apr 4, 2023

probably incorrect flags value in assertion #21005

Open

KES777 mentioned this pull request May 31, 2023

File content is used as subroutine name when exception occur while eval'ing from sub DB::DB{ ... } #21102

Closed

khwilliamson referenced this pull request in khwilliamson/perl5 Jul 16, 2023

Merge pull request #1 from guillemj/pu/no-use-vars

f871aa1

Switch from «use vars» to «our» or «my»

DanFreed mentioned this pull request Jul 28, 2023

POSIX::SigSet / SigAction hang or core dump #21308

Closed

jjn1056 mentioned this pull request Aug 7, 2023

experimental 'class' doesn't work with existing objects #21331

Open

daniel-pfeiffer mentioned this pull request Aug 13, 2023

bignum >= 0.51 breaks BigInt >> #21370

Open

AlexeiKharchev mentioned this pull request Oct 8, 2023

perl-5.38 compilation error (regcomp.o and lib/auto/re/re.a(re_comp.o) conflict) #21550

Closed

hulkster mentioned this pull request Nov 5, 2023

Easy way (?) to get Benchmark.pm (with Time::HiRes) to show 6 (versus 5) decimal points of accuracy #21618

Open

igorlord mentioned this pull request Jan 4, 2024

Perl misinterprets hashrefs as strings in some special situations #21797

Closed

qingliu111 mentioned this pull request Mar 5, 2024

Failed tests of pm_to_blib.t occurred during the installation of perl-5.38.2 #22064

Closed

jdv mentioned this pull request Jul 23, 2024

Use of uninitialized value $_[0] in defined operator #22423

Closed

Tux mentioned this pull request Jan 23, 2025

perl -V being mockable is a security problem re: #21135 Errno archname/osvers too strict. #22939

Open

Flamefire mentioned this pull request May 7, 2025

[doc] Changing libpth for building extensions #23267

Closed

lillianokok mentioned this pull request Jun 6, 2025

executing the test command dist/ExtUtils-CBuilder/t/03-cplusplusplus fails, #23355

Closed

jkeenan mentioned this pull request Jun 9, 2025

perldoc does not generate doc properly if run as root and file is not world readable #17701

Closed

djerius mentioned this pull request Jul 28, 2025

perldb improperly handles blessed coderefs #23486

Open

endocrantz mentioned this pull request Sep 16, 2025

pp.c build problem with Dusethreads 5.42 (perl5-5.43.2 as well) #23713

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update perlhack.pod - fix link to mirror git repo #1

Update perlhack.pod - fix link to mirror git repo #1

Uh oh!

MartinMcGrath commented Dec 18, 2013

Uh oh!

Uh oh!

Update perlhack.pod - fix link to mirror git repo #1

Update perlhack.pod - fix link to mirror git repo #1

Uh oh!

Conversation

MartinMcGrath commented Dec 18, 2013

Uh oh!

Uh oh!