-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PATCH] consting in Collate.xs #11460
Comments
From rmbarker.cpan@btinternet.comCreated by rmbarker.cpan@btinternet.comCollate.xs in Unicode-Collate gives compiler warnings with Perl Info
|
From rmbarker.cpan@btinternet.com0001-consting-in-cpan-Unicode-Collate-Collate.xs.patchFrom f0b7cdc5647228baf01af439be2f0102cd79e436 Mon Sep 17 00:00:00 2001
From: Robin Barker <rmbarker@cpan.org>
Date: Wed, 22 Jun 2011 21:06:46 +0100
Subject: [PATCH] consting in cpan/Unicode-Collate/Collate.xs
Add C<const> to declaration of C<char *> in Collate.xs
that are used for fixed strings.
Silences compiler warnings [-Wwrite-strings]
---
cpan/Unicode-Collate/Collate.xs | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/cpan/Unicode-Collate/Collate.xs b/cpan/Unicode-Collate/Collate.xs
index 7f00642..d9c14a6 100644
--- a/cpan/Unicode-Collate/Collate.xs
+++ b/cpan/Unicode-Collate/Collate.xs
@@ -249,7 +249,7 @@ getHST (code, uca_vers = 0)
UV code;
IV uca_vers;
PREINIT:
- char * hangtype;
+ const char * hangtype;
STRLEN typelen;
CODE:
if (codeRange(Hangul_SIni, Hangul_SFin)) {
@@ -632,7 +632,7 @@ visualizeSortKey (self, key)
STRLEN klen, dlen;
UV uv;
IV uca_vers;
- static char *upperhex = "0123456789ABCDEF";
+ static const char *upperhex = "0123456789ABCDEF";
CODE:
if (SvROK(self) && SvTYPE(SvRV(self)) == SVt_PVHV)
selfHV = (HV*)SvRV(self);
--
1.7.1
|
From @cpansproutLet’s see what happens if I forward this to the CPAN queue from within On Fri Jun 24 05:13:56 2011, rmbarker.cpan@btinternet.com wrote:
PATH=/home/robin/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games
|
The RT System itself - Status changed from 'new' to 'open' |
From bug-Unicode-Collate@rt.cpan.org<URL: https://rt.cpan.org/Ticket/Display.html?id=69133 > On 2011-6月-28 火 13:52:42, perlbug-followup@perl.org wrote:
Thanks, applied. Unicode::Collate 0.77 will come soon. |
@cpansprout - Status changed from 'open' to 'resolved' |
Migrated from rt.perl.org#93470 (status was 'resolved')
Searchable as RT93470$
The text was updated successfully, but these errors were encountered: