-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Race condition in test IO/t/io_unix.t #15058
Comments
From sergle.ua@gmail.comWhen trying to compile perl-5.22.0 on Linux Ubuntu 14.04 inside VirtualBox, Test is ok when I tried to compile Perl just in Linux without VirtualBox. Test failed because 'ok 4' is missing from output. With attached patch all tests passed in VirtualBox VM. -- |
From sergle.ua@gmail.comio_unix_test.patchdiff --git a/dist/IO/t/io_unix.t b/dist/IO/t/io_unix.t
index 61ba363..3fcf376 100644
--- a/dist/IO/t/io_unix.t
+++ b/dist/IO/t/io_unix.t
@@ -85,9 +85,10 @@ if($pid = fork()) {
print $sock "ok 4\n";
+ waitpid($pid,0);
+
$sock->close;
- waitpid($pid,0);
unlink($PATH) || $^O eq 'os2' || warn "Can't unlink $PATH: $!";
print "ok 5\n";
|
From @jkeenanOn Sat Nov 21 17:27:17 2015, sergle.ua@gmail.com wrote:
Smoke-testing in branch smoke-me/jkeenan/126707-waitpid. In particular, we need to see what the impact of this revision is on the test's performance on OSes other than Linux. Thank you very much. |
The RT System itself - Status changed from 'new' to 'open' |
From @tonycozOn Sat Nov 21 17:27:17 2015, sergle.ua@gmail.com wrote:
That explanation seems strange on Linux, I know Win32 sockets (which doesn't support UNIX sockets) tends to discard buffered data when the sender closes, but that shouldn't be the case on Linux. I've run make test many times in VirtualBox VMs, though not recently. Updating my Ubuntu VM now for further testing. Tony |
From sergle.ua@gmail.comOn Wed, Nov 25, 2015 at 2:00 AM, Tony Cook via RT <perlbug-followup@perl.org
This may be a reason, because I run VirtulBox (latest 5.0.10) with Ubuntu -- |
From sergle.ua@gmail.comThis may be a reason, because I run VirtulBox (latest 5.0.10) with Ubuntu -- |
From @tonycozOn Wed, 25 Nov 2015 05:20:22 -0800, sergle.ua@gmail.com wrote:
Can you still reproduce this? This can't be associated with the host - Unix sockets are implemented in the guest (and Win32 doesn't have Unix sockets anyway). Tony |
From sergle.ua@gmail.comOn Tue, Oct 17, 2017 at 2:21 AM, Tony Cook via RT <perlbug-followup@perl.org
Now with VirtualBox 5.1.28 and Ubuntu 16.04 as guest OS issue is not -- |
From @jkeenanOn Thu, 19 Oct 2017 13:26:37 GMT, sergle.ua@gmail.com wrote:
This ticket seems closable. TonyC, do you concur? Thank you very much. |
From @tonycozOn Fri, 20 Oct 2017 19:20:54 -0700, jkeenan wrote:
Yes, closed. Tony |
@tonycoz - Status changed from 'open' to 'rejected' |
Migrated from rt.perl.org#126707 (status was 'rejected')
Searchable as RT126707$
The text was updated successfully, but these errors were encountered: