-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ExtUtils::ParseXS: Please make the output reproducible #15414
Comments
From carnil@debian.orgHi Chris Lamb working on the "reproducible builds" effort [0] reported that the output generated by ExtUtils::ParseXS is non-deterministic and proposed a patch both in [1] and [2], basically boiling down to: Inline Patchdiff --git a/dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS.pm b/dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS.pm
index 0987500..dd1c3f2 100644
--- a/dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS.pm
+++ b/dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS.pm
@@ -686,7 +686,7 @@ EOF
var => $_,
do_setmagic => $self->{DoSetMagic},
do_push => undef,
- } ) for grep $self->{in_out}->{$_} =~ /OUT$/, keys %{ $self->{in_out} };
+ } ) for grep $self->{in_out}->{$_} =~ /OUT$/, sort keys %{ $self->{in_out} };
my $prepush_done;
# all OUTPUT done, so now push the return value on the stack
Regards, [0] https://wiki.debian.org/ReproducibleBuilds |
From @jkeenanOn Sat Jul 02 01:05:26 2016, carnil@debian.org wrote:
Other things being equal, I would expect the introduction of a 'sort' function at that point to cause a performance hit. -- |
The RT System itself - Status changed from 'new' to 'open' |
From zefram@fysh.orgJames E Keenan via RT wrote:
Not a concern. This only runs during build processes. -zefram |
From @jkeenanOn Sat Jul 02 05:50:15 2016, zefram@fysh.org wrote:
Okay. Smoke-testing in branch smoke-me/jkeenan/128517-eupxs. -- |
From @tonycozOn Sun Jul 03 07:55:55 2016, jkeenan wrote:
Which I don't see new failures on. Thanks, applied as aeb9a30. Removed the smoke-me branch. Tony |
@tonycoz - Status changed from 'open' to 'pending release' |
From @khwilliamsonThank you for filing this report. You have helped make Perl better. With the release today of Perl 5.26.0, this and 210 other issues have been Perl 5.26.0 may be downloaded via: If you find that the problem persists, feel free to reopen this ticket. |
@khwilliamson - Status changed from 'pending release' to 'resolved' |
Migrated from rt.perl.org#128517 (status was 'resolved')
Searchable as RT128517$
The text was updated successfully, but these errors were encountered: