[feature] Make default typemap type-mismatch errors give the passed-in SV’s information

[FGasper]

I’m chasing one of these:

    (in cleanup) DNS::Unbound::_destroy_context: ctx is not of type struct ub_ctxPtr at /usr/local/cpanel/3rdparty/perl/532/lib/perl5/cpanel_lib/x86_64-linux-64int/DNS/Unbound.pm line 731 during global destruction.

Currently DNS::Unbound uses the default T_PTROBJ typemap. I’m about to push up a change to the module to use a custom typemap that will print this instead:

DNS::Unbound::_destroy_context: ctx (scalar: 123123) is not of type struct ub_ctxPtr at …

I thought I’d throw this up here to gauge interest in making this change to upstream. I’m including a provisional PR.

Thank you!

[tonycoz]

Looking at the commit in your repository:

const char* valstr = SvROK($arg) ? sv_2pvbyte_nolen($arg) : SvPV_nolen($arg);

why differentiate? (and why call the function directly?) Also, the object could be blessed into a non-ASCII package name,

Also this could just use the SVf macro:

Perl_croak_nocontext(\"%s: %s (%s" SVf ") is not of type %s\",

and supply $arg instead of valstr. This also handles unicode strings and stash names for blessed objects.

[jkeenan]

@FGasper, would you like to respond to @tonycoz's reply? Otherwise, it looks like we should close this feature request.

Thank you very much.
Jim Keenan

[FGasper]

@jkeenan I updated the PR to incorporate @tonycoz’s suggestion a bit back. I didn’t update this thread though .. sorry. :(