fix magic and upgraded SV handling for setsockopt()'s OPTVAL #18660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code here checked SV flags before fetching magic, potentially getting confused if magic fetched changed flags. This also fixes handling for upgraded SVs, but I'm not sure that can be tested sufficiently portably.
tonycoz
force-pushed
the
18642-setsockopt-magic
branch
from
66d150f
to
511f1d6
Compare
|
@tonycoz FWIW, here is my test for handling of setsockopt upgraded SV: https://github.com/FGasper/p5-Sys-Binmode/blob/master/t/net_setsockopt.t As you mention, it’s a bit cross-platform-rickety. It seems to pass CPAN testers reliably, but of course there are many platforms that that doesn’t test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code here checked SV flags before fetching magic, potentially
getting confused if magic fetched changed flags.
This also fixes handling for upgraded SVs, but I'm not sure that can
be tested sufficiently portably.