-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
$) and $( should be IOKp but not IOK #18955
Comments
This causes Sereal/Sereal#263 |
note that it's coming from the Line 1227 in c683824
My understanding is the issue is when serializing the data. |
Issue Perl#18955: This will prevent serializers from serializing these variables as numbers (which loses the additional groups).
Issue Perl#18955: This will prevent serializers from serializing these variables as numbers (which loses the additional groups). This restores behaviour from 5.16.
Issue Perl#18955: This will prevent serializers from serializing these variables as numbers (which loses the additional groups). This restores behaviour from 5.16.
Issue Perl#18955: This will prevent serializers from serializing these variables as numbers (which loses the additional groups). This restores behaviour from 5.16.
Issue Perl#18955: This will prevent serializers from serializing these variables as numbers (which loses the additional groups). This restores behaviour from 5.16.
Issue Perl#18955: This will prevent serializers from serializing these variables as numbers (which loses the additional groups). This restores behaviour from 5.16.
Bisecting, you can look at:
If it gives back IOK, then the bug is still there. At which point you can bisect it to:
|
Issue #18955: This will prevent serializers from serializing these variables as numbers (which loses the additional groups). This restores behaviour from 5.16.
Fix is in blead. |
Issue Perl#18955: This will prevent serializers from serializing these variables as numbers (which loses the additional groups). This restores behaviour from 5.16.
The fact that this is marked IOK tells XS modules (e.g., Sereal) that the IV value is legitimate. That’s sort of true, but it’s inconsistent with Perl’s typical behaviour of invalidating IOK whenever the IV mismatches the PV, which is the case here.
Note that leaving the private flag (IOKp) in place will prevent not-a-number warnings.
The text was updated successfully, but these errors were encountered: