-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regexp branch reset changes broke $+ #20912
Labels
Comments
Thanks, ill investigate later. Yves |
demerphq
added a commit
that referenced
this issue
Mar 8, 2023
I missed that $+ needs to do the parno_to_logical lookup. We had tests for $^N, but not $+. This also fixes the code for $^N to only do the lookup when the paren is not 0. Fixes #20912
Thank you for the report. Fixed pushed as #20913 |
demerphq
added a commit
that referenced
this issue
Mar 8, 2023
I missed that $+ needs to do the parno_to_logical lookup. We had tests for $^N, but not $+. This also fixes the code for $^N to only do the lookup when the paren is not 0. Fixes #20912
pjacklam
pushed a commit
to pjacklam/perl5
that referenced
this issue
May 20, 2023
I missed that $+ needs to do the parno_to_logical lookup. We had tests for $^N, but not $+. This also fixes the code for $^N to only do the lookup when the paren is not 0. Fixes Perl#20912
pjacklam
pushed a commit
to pjacklam/perl5
that referenced
this issue
May 20, 2023
I missed that $+ needs to do the parno_to_logical lookup. We had tests for $^N, but not $+. This also fixes the code for $^N to only do the lookup when the paren is not 0. Fixes Perl#20912
khwilliamson
pushed a commit
to khwilliamson/perl5
that referenced
this issue
Jul 10, 2023
I missed that $+ needs to do the parno_to_logical lookup. We had tests for $^N, but not $+. This also fixes the code for $^N to only do the lookup when the paren is not 0. Fixes Perl#20912
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
At least in 5.37.8 and 5.37.10 and blead of today, the cooperation between branch reset and
$+
is broken.Very probably related to #20710, but a different effect of the same change.
Steps to Reproduce
This should produce "found b", but produces a "fail!"
Perl configuration
The text was updated successfully, but these errors were encountered: