-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apostrophe in name removal #22303
Apostrophe in name removal #22303
Conversation
I scanned the changes and ran the tests on FreeBSD; got PASS. LGTM but the C-level changes would benefit from other eyeballs. |
} | ||
#if PERL_VERSION_LT(5, 41, 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if the 0 is still valid? and elsewhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We won't know what it should be until it's approved and merged.
|
1026a56
to
68bcecd
Compare
Thanks.
I couldn't see a way to test these, but removed the left over code.
This one had observable behaviour which I added a test for. |
I assume this PR calls for an update to perldata, under the heading
There's also a big old regex in that section with rules for parsing identifiers. |
|
@tonycoz, could you respond to the 2 preceding comments in this ticket? Thanks. |
68bcecd
to
14bbe6f
Compare
I've added updates to perldata and perlmod, I expect they will be squashed into the top commit on merge. |
14bbe6f
to
d359ce2
Compare
d359ce2
to
eda8f37
Compare
In general for tests I translate them to using :: if the test wasn't specifically for ', and the test didn't duplicate a similar test that did test ::. This doesn't just change the parsing stage from accepting ' instead of :: in names, but also removes the translation from ' to :: done in several places, but that's really there to support the syntax.
eda8f37
to
44f6818
Compare
applied manually, thanks everyone |
Do the removal described in perldeprecation
=head3 Use of C<'> as a global name separator
Perl allows use of C<'> instead of C<::> to replace the parts of a
package or global variable name, for example C<A::B> and C<A'B> are
equivalent.
C<'> will no longer be recognized as a name separator in Perl 5.42.