Move PL_check to the interp vars to fix threading issues

[niner]

Fixes issue #14816

[tonycoz]

This fails tests and can't be merged as is.

[jkeenan]

I checked out e30e36f, rebased it on blead (resolving the merge conflict in opcode.h), configured with threads and tried to build. make died pretty quickly.

echo @`sh  cflags "optimize='-O2'" opmini.o`  -DPERL_IS_MINIPERL -DPERL_EXTERNAL_GLOB opmini.c
@cc -c -DPERL_CORE -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -std=c89 -O2 -Wall -Werror=pointer-arith -Wextra -Wc++-compat -Wwrite-strings -Werror=declaration-after-statement -DPERL_IS_MINIPERL -DPERL_EXTERNAL_GLOB opmini.c
echo @`sh  cflags "optimize='-O2'" perlmini.o`  -DPERL_IS_MINIPERL -DPERL_EXTERNAL_GLOB perlmini.c
@cc -c -DPERL_CORE -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -std=c89 -O2 -Wall -Werror=pointer-arith -Wextra -Wc++-compat -Wwrite-strings -Werror=declaration-after-statement -DPERL_IS_MINIPERL -DPERL_EXTERNAL_GLOB perlmini.c
In file included from perl.c:35:0:
EXTERN.h:49:24: error: expected ‘,’ or ‘;’ before ‘extern’
 #      define EXTCONST extern const
                        ^
opcode.h:1784:1: note: in expansion of macro ‘EXTCONST’
 EXTCONST U32 PL_opargs[];
 ^
makefile:311: recipe for target 'perlmini.o' failed
make: *** [perlmini.o] Error 1

This p.r. is not yet sufficiently well formulated to proceed. @niner, can you re-investigate?

Thank you very much.
Jim Keenan

[atoomic]

@tonycoz is this ok to merge this PR now?

[tonycoz]

@tonycoz is this ok to merge this PR now?

No, it breaks code that depends on wrap_op_checker(), see #14816 for details.

There will need to be a change that includes this change, but wrap_op_checker() will need to be improved too.

[toddr]

Hi, this PR cannot be merged as is. Please re-submit when you have addressed the concerns raised by tonycoz. Thanks!