Add dualvar-creating newSVpviv and friends #17811
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two new functions and one macro create PV-and-IV dualvars, in
similar style to the other newSV*() family.
They are most convenient for wrapping error values from external
libraries, to create dual number/string values in a similar style to
core's $! wrapping of errno.
For example:
int err = uv_...();
if(err != 0) return newSVpviv(uv_strerr(err), err);
This makes the usual style of error-type dualvar that can both be tested
for numerical equality and additionally used as a string to yield its
human-readable error message
croak "Unable to complete: $err" unless $err == UV::UV_EAGAIN;
|
@leonerd per the mailing list, does this change need more work or are we discarding it? |
salva
reviewed
Apr 9, 2021
| { | ||
| SV *sv = newSViv(i); | ||
| if(!sv) return newSViv(i); | ||
|
|
There was a problem hiding this comment.
The code above doesn't make sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two new functions and one macro create PV-and-IV dualvars, in similar style to the other
newSV*()family.They are most convenient for wrapping error values from external libraries, to create dual number/string values in a similar style to core's
$!wrapping oferrno.For example:
This makes the usual style of error-type dualvar that can both be tested for numerical equality and additionally used as a string to yield its human-readable error message
(this PR is a continuation of #17807 which I shall now close)