Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GNU/Hurd doesn't support SO_PROTOCOL #17873

Merged
merged 1 commit into from
Jul 30, 2020
Merged

Conversation

sthibaul
Copy link
Contributor

No description provided.

@ntyni
Copy link
Contributor

ntyni commented Jun 18, 2020

Just noting that the test failure fixed by this is a 5.32 regression on Hurd.

@ntyni
Copy link
Contributor

ntyni commented Jun 18, 2020

@sthibaul did you test this? The build log at https://buildd.debian.org/status/fetch.php?pkg=perl&arch=hurd-i386&ver=5.32.0%7Erc1-1&stamp=1592442236&raw=0 has two failures, so I assume the system list on line 108 needs updating too.

@sthibaul
Copy link
Contributor Author

Ah, no I hadn't tested it, because the issue was so obvious, and pointed to me by https://lists.debian.org/debian-hurd/2020/06/msg00028.html

Copy link
Contributor

@khwilliamson khwilliamson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, though I don't know if 'gnu' is the precise correct string; but if it weren't @jmdh would have said something

@sthibaul
Copy link
Contributor Author

sthibaul commented Jun 19, 2020

'gnu' can be seen already used in various places:

dist/Time-HiRes/t/itimer.t:            && $^O ne 'gnu' # GNU/Hurd: has the API but no implementation
ext/POSIX/t/sigaction.t:            ($^O eq 'gnu')
t/io/socket.t:		    if $^O eq "gnu";

@jmdh
Copy link
Member

jmdh commented Jun 19, 2020

Yep, I think "gnu" is correct.

@Leont
Copy link
Contributor

Leont commented Jun 20, 2020

LGTM

@khwilliamson khwilliamson merged commit 51581d5 into Perl:blead Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants