Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream cygwin patches #18534

Merged
merged 4 commits into from Jun 14, 2022
Merged

Upstream cygwin patches #18534

merged 4 commits into from Jun 14, 2022

Conversation

Leont
Copy link
Contributor

@Leont Leont commented Feb 7, 2021

Cygwin is currently applying these patches to their perl. I suspect we should apply them ourselves instead.

Note: I didn't write any of these, and can't vouch for them or test them.

@Leont Leont mentioned this pull request Feb 7, 2021
@Leont Leont marked this pull request as draft February 7, 2021 01:41
@Leont
Copy link
Contributor Author

Leont commented Feb 7, 2021

The auto-image, hints, libsearch and readme patches look non-controversial to me.

The libpth patch had me confused for a moment. It's actually fixing a bug that exists on all platforms that use Configure, where include paths that don't end on /include will erroneously end up in libpth (e.g. /usr/lib/gcc/x86_64-pc-linux-gnu/10.2.0/include-fixed in my particular case). I would have written it differently but it seems correct (and necessary on other platforms as well).

The Win32 patch breaks on Windows, in particular Unicode.t. I think we should just leave it out.

@Leont Leont requested review from Tux, xenu and wchristian February 7, 2021 16:19
hints/cygwin.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@Tux Tux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok

Configure Outdated Show resolved Hide resolved
Configure Outdated Show resolved Hide resolved
@xenu
Copy link
Member

xenu commented Feb 10, 2021

The Win32 patch breaks on Windows, in particular Unicode.t. I think we should just leave it out.

Yeah, the Win32 part should be skipped. I don't understand the purpose of those changes and it seems leaving them out doesn't break the tests on cygwin.

hints/cygwin.sh Outdated Show resolved Hide resolved
Configure Outdated Show resolved Hide resolved
@Leont Leont force-pushed the leont/cygwin-downstream branch 2 times, most recently from 700bc38 to 26219f6 Compare April 23, 2022 11:27
@Leont Leont marked this pull request as ready for review April 23, 2022 11:28
@Leont
Copy link
Contributor Author

Leont commented Apr 23, 2022

I cut out the pieces that were controversial or seemed dubious, I think this can be merged in early 5.37

hints/cygwin.sh Outdated Show resolved Hide resolved
At the time this document was last updated, Cygwin 1.7.16 was current.
At the time this document was last updated, Cygwin 3.0.7 was current.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ uname -a
CYGWIN_NT-10.0 GANYMEDE 3.3.5(0.341/5/3) 2022-05-13 12:27 x86_64 Cygwin

@Leont Leont merged commit eceace5 into blead Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants