New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upstream cygwin patches #18534
Upstream cygwin patches #18534
Conversation
The auto-image, hints, libsearch and readme patches look non-controversial to me. The libpth patch had me confused for a moment. It's actually fixing a bug that exists on all platforms that use The Win32 patch breaks on Windows, in particular |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok
Yeah, the Win32 part should be skipped. I don't understand the purpose of those changes and it seems leaving them out doesn't break the tests on cygwin. |
700bc38
to
26219f6
Compare
I cut out the pieces that were controversial or seemed dubious, I think this can be merged in early 5.37 |
26219f6
to
1875d71
Compare
1875d71
to
d7dbfd0
Compare
At the time this document was last updated, Cygwin 1.7.16 was current. | ||
At the time this document was last updated, Cygwin 3.0.7 was current. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$ uname -a
CYGWIN_NT-10.0 GANYMEDE 3.3.5(0.341/5/3) 2022-05-13 12:27 x86_64 Cygwin
Cygwin is currently applying these patches to their perl. I suspect we should apply them ourselves instead.
Note: I didn't write any of these, and can't vouch for them or test them.