Provide strict compliance for DynaLoader and XSLoader #18662
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonycoz
requested changes
Mar 25, 2021
Leont
force-pushed
the
leont/xs_dynaloader
branch
from
9484cdf
to
aabedb3
Compare
Now we're using our, there's no value to attempting to support versions below 5.6.
Leont
force-pushed
the
leont/xs_dynaloader
branch
from
aabedb3
to
f0cc16d
Compare
tonycoz
approved these changes
Jun 14, 2021
|
Given @tonycoz's approval, locally rebased on blead, tested, merged into blead, re-tested, pushed to origin. Closing this p.r. Thank you very much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is an alternative to #18221
The main difference between that branch and this is that this one will not break bootstrap files, as described here.