Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report Data::Dumper problems to Perl 5 Github issues queue #18832

Closed
wants to merge 1 commit into from

Conversation

jkeenan
Copy link
Contributor

@jkeenan jkeenan commented May 28, 2021

In the commit message for 29c66c4,
Nicholas Clark wrote:

Really we should decide *which* bugtracker is canonical for Data::Dumper
(and will be checked and acted upon) and then record that metadata in this
Makefile.PL so that [metacpan.org, etc., can] link to it.

Let's provide that information based on the examples of other
blead-upstream distros under dist, dist/Module-CoreList/Makefile.PL
and dist/PathTools/Makefile.PL.

In the commit message for 29c66c4,
Nicholas Clark wrote:

    Really we should decide *which* bugtracker is canonical for Data::Dumper
    (and will be checked and acted upon) and then record that metadata in this
    Makefile.PL so that [metacpan.org, etc., can] link to it.

Let's provide that information based on the examples of other
blead-upstream distros under `dist`, `dist/Module-CoreList/Makefile.PL`
and `dist/PathTools/Makefile.PL`.
@jkeenan jkeenan requested a review from nwc10 May 28, 2021 22:17
@neilb
Copy link
Contributor

neilb commented Jun 13, 2021

We discussed this issue in this week's PSC meeting.

We reckon that, in general, upstream blead distributions should direct users to Perl's issue queue. So in that context, we think that this change is right.

I guess that means the following should happen:

  1. Move all the (open, at least) issues from rt.cpan.org to Perl's github issues
  2. Do a release of DD to CPAN that has the bugtracker in metadata pointing to Perl's queue, and then RT will direct them there, and MetaCPAN will too
  3. For extra credit, could also set the Distribution notes on RT (click on "Manage" in RT) to say that this is a core module and so bugs are tracked along with Perl itself.
  4. What have I missed?

@jkeenan
Copy link
Contributor Author

jkeenan commented Jun 13, 2021

We discussed this issue in this week's PSC meeting.

We reckon that, in general, upstream blead distributions should direct users to Perl's issue queue. So in that context, we think that this change is right.

I guess that means the following should happen:

1. Move all the (open, at least) issues from rt.cpan.org to Perl's github issues

There are currently 30 28 tickets in Data-Dumper's upstream bug queue, each of which is more than two years old.

I don't relish the idea of importing all these tickets into our bug tracker without first reviewing them to see which ones can be handled quickly. I acknowledge that the fact that these tickets are all so old implies that they were not quickly resolvable till now.

Perhaps we could appoint a task force of people (including at least one person who can work with Dumper.xs) to plow through these tickets and reduce the number we'd have to import.

[snip]

Thank you very much.
Jim Keenan

@jkeenan
Copy link
Contributor Author

jkeenan commented Jun 20, 2021

[snip]

There are currently 28 tickets in Data-Dumper's upstream bug queue, each of which is more than two years old.

I don't relish the idea of importing all these tickets into our bug tracker without first reviewing them to see which ones can be handled quickly. I acknowledge that the fact that these tickets are all so old implies that they were not quickly resolvable till now.

Perhaps we could appoint a task force of people (including at least one person who can work with Dumper.xs) to plow through these tickets and reduce the number we'd have to import.

I have now reviewed those 28 tickets and entered comments in most of them. Some of them appear to be directly closable; others should be rejected. But IMO we still need "a task force of people (including at least one person who can work with Dumper.xs) to plow through these tickets and reduce the number we'd have to import.."

Thank you very much.
Jim Keenan

@nwc10 nwc10 self-assigned this Jun 29, 2021
@nwc10
Copy link
Contributor

nwc10 commented Jun 29, 2021

I agree that it's not perfect, but I think that it's better than what we had. We can build on this.

I've rolled this up as part of a Data-Dumper-2.181_50.tar.gz dev release to CPAN. We'll see what the cpan testers make of it over the next couple of days.

@jkeenan
Copy link
Contributor Author

jkeenan commented Jun 29, 2021

I agree that it's not perfect, but I think that it's better than what we had. We can build on this.

I've rolled this up as part of a Data-Dumper-2.181_50.tar.gz dev release to CPAN. We'll see what the cpan testers make of it over the next couple of days.

Can you say where the source code for that dev release is located?

Thank you very much.
Jim Keenan

@nwc10
Copy link
Contributor

nwc10 commented Jun 29, 2021

https://github.com/nwc10/perl5/tree/Data-Dumper-2.181

But I misnamed my branch - probably it should be named Data-Dumper-2.182, so I'm probably going to correct that soon.

@nwc10
Copy link
Contributor

nwc10 commented Jun 30, 2021

Pushed to blead and shipped to CPAN as 2.182

@nwc10 nwc10 closed this Jun 30, 2021
@jkeenan jkeenan added the dist-Data-Dumper issues in the dual-life blead-first Data-Dumper distribution label Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dist-Data-Dumper issues in the dual-life blead-first Data-Dumper distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants