Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regcomp.c: Split a too-large-function into two #18835

Closed
wants to merge 8 commits into from
Closed

regcomp.c: Split a too-large-function into two #18835

wants to merge 8 commits into from

Commits on Jun 2, 2021

  1. regcomp.c: White-space only 

    My attempt to insulate from the leading tab removal the year-old commits
finally pushed as 77a6d54 and
403d7eb failed miserably.

I think it is some bug in git.  Seemingly random groups of lines were
indented differently than adjacent ones.

Anyway, I spent a bunch of time sorting it all out, and this is the
result.
    @khwilliamson
    khwilliamson committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    c6a115c View commit details
    Browse the repository at this point in the history

  2. regcomp.c: comments 

    Comment change suggestions from @hvds in PR Perl#18835.
    @hvds @khwilliamson
    hvds authored and khwilliamson committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    bb5a3bb View commit details
    Browse the repository at this point in the history

  3. regcomp.c: S_optimize_regclass() return 0 if fail 

    Based on a comment from @hvds, I think it better if this function return
an impossible node value if it didn't find a node to use.
    @khwilliamson
    khwilliamson committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    02815c2 View commit details
    Browse the repository at this point in the history

  4. regcomp.c: Consolidate duplicate code

    @khwilliamson
    khwilliamson committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    45bf64d View commit details
    Browse the repository at this point in the history

  5. regcomp.c: Move some code to within a block 

    This code is irrelevant unless the condition of the block immediately
before it is TRUE, so move it to within that block.
    @khwilliamson
    khwilliamson committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    f974d37 View commit details
    Browse the repository at this point in the history

  6. regcomp.c: Add a clearer mnemonic

    @khwilliamson
    khwilliamson committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    d070adf View commit details
    Browse the repository at this point in the history

  7. regcomp.c: Save a value instead of re-calling fcn 

    This variable will be used in future commits in more places, so compute
it just once.
    @khwilliamson
    khwilliamson committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    1402c65 View commit details
    Browse the repository at this point in the history

  8. regcomp.c: Initialize a variable 

    to silence some compiler's that were warning
    @khwilliamson
    khwilliamson committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    998c08b View commit details
    Browse the repository at this point in the history