Create defer syntax and OP_PUSHDEFER opcode (RFC 0004)
#19019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonerd
force-pushed
the
defer
branch
3 times, most recently
from
cc297fe
to
33b620f
Compare
tonycoz
reviewed
Aug 25, 2021
| invoke_defer_block(pTHX_ void *_arg) | ||
| { | ||
| OP *start = (OP *)_arg; | ||
| I32 was_cxstack_ix = cxstack_ix; |
There was a problem hiding this comment.
this variable is unused in non-DEBUGGING builds
There was a problem hiding this comment.
Ahyes. Now fixed in a488435. (I'll squash before merging)
|
Except for the unused variable, it looks good to me. |
Adds syntax `defer { BLOCK }` to create a deferred block; code that is
deferred until the scope exits. This syntax is guarded by
use feature 'defer';
Adds a new opcode, `OP_PUSHDEFER`, which is a LOGOP whose `op_other` field
gives the start of an optree to be deferred until scope exit. That op
pointer will be stored on the save stack and invoked as part of scope
unwind.
Included is support for `B::Deparse` to deparse the optree back into
syntax.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds syntax
defer { BLOCK }to create a deferred block; code that is deferred until the scope exits. This syntax is guarded byAdds a new opcode,
OP_PUSHDEFER, which is a LOGOP whoseop_otherfield gives the start of an optree to be deferred until scope exit. That op pointer will be stored on the save stack and invoked as part of scope unwind.Included is support for
B::Deparseto deparse the optree back into syntax.This PR relates to RFC 0004 - https://github.com/Perl/RFCs/blob/master/rfcs/rfc0004.md