Make new makedepend logic compatible with bsd make

[Leont]

It used pattern rules, which are a gnu make feature that isn't supported by bsd makes (and probably other makes)

This fixes #19046

[jkeenan]

Testing on affected OSes.

[jkeenan]

When I tried this branch on FreeBSD-12, ./Configure appeared to run well as did make. But I got these test failures:

[perlmonger: perl] $ cd t;TEST_JOBS=1 ./perl harness -v ../cpan/version/t/07locale.t ../ext/POSIX/t/posix.t \
> ../lib/locale.t
../cpan/version/t/07locale.t .. 
1..8
ok 1 - use version;
ok 2 - Not using locale yet
Failed 6/8 subtests 

../ext/POSIX/t/posix.t ........ 
1..98
ok 1 - O_RDONLY with open
ok 2 -     with read
not ok 3 -     read to array element # TODO read to array element not working
#   Failed (TODO) test '    read to array element'
#   at t/posix.t line 65.
#          got: undef
#     expected: 'perl
# '
ok 4
...
ok 51 - Can import autoloaded constants
Failed 47/98 subtests 
	(less 1 skipped subtest: 50 okay)
	
../lib/locale.t ............... 
ok 1 Verify locales_enabled('ALL') returns 0 or 1
ok 2    and locales_enabled('LC_ALL') returns the same value
...
ok 380 verify that isn't tainted:  "foo.bar_baz" =~ /^(.*)[._](.*?)$/
All 380 subtests passed 

Test Summary Report
-------------------
../cpan/version/t/07locale.t (Wstat: 139 Tests: 2 Failed: 0)
  Non-zero wait status: 139
  Parse errors: Bad plan.  You planned 8 tests but ran 2.
../ext/POSIX/t/posix.t      (Wstat: 139 Tests: 51 Failed: 0)
  Non-zero wait status: 139
  Parse errors: Bad plan.  You planned 98 tests but ran 51.
../lib/locale.t             (Wstat: 139 Tests: 380 Failed: 0)
  Non-zero wait status: 139
  Parse errors: No plan found in TAP output
Files=3, Tests=433,  4 wallclock secs ( 0.04 usr  0.00 sys +  0.23 cusr  0.09 csys =  0.37 CPU)
Result: FAIL

I may not have time to fully examine these failures tonight.

[jkeenan]

When I tried this branch on FreeBSD-12, ./Configure appeared to run well as did make. But I got these test failures:

[perlmonger: perl] $ cd t;TEST_JOBS=1 ./perl harness -v ../cpan/version/t/07locale.t ../ext/POSIX/t/posix.t \
> ../lib/locale.t
../cpan/version/t/07locale.t .. 
1..8
ok 1 - use version;
ok 2 - Not using locale yet
Failed 6/8 subtests 

../ext/POSIX/t/posix.t ........ 
1..98
ok 1 - O_RDONLY with open
ok 2 -     with read
not ok 3 -     read to array element # TODO read to array element not working
#   Failed (TODO) test '    read to array element'
#   at t/posix.t line 65.
#          got: undef
#     expected: 'perl
# '
ok 4
...
ok 51 - Can import autoloaded constants
Failed 47/98 subtests 
	(less 1 skipped subtest: 50 okay)
	
../lib/locale.t ............... 
ok 1 Verify locales_enabled('ALL') returns 0 or 1
ok 2    and locales_enabled('LC_ALL') returns the same value
...
ok 380 verify that isn't tainted:  "foo.bar_baz" =~ /^(.*)[._](.*?)$/
All 380 subtests passed 

Test Summary Report
-------------------
../cpan/version/t/07locale.t (Wstat: 139 Tests: 2 Failed: 0)
  Non-zero wait status: 139
  Parse errors: Bad plan.  You planned 8 tests but ran 2.
../ext/POSIX/t/posix.t      (Wstat: 139 Tests: 51 Failed: 0)
  Non-zero wait status: 139
  Parse errors: Bad plan.  You planned 98 tests but ran 51.
../lib/locale.t             (Wstat: 139 Tests: 380 Failed: 0)
  Non-zero wait status: 139
  Parse errors: No plan found in TAP output
Files=3, Tests=433,  4 wallclock secs ( 0.04 usr  0.00 sys +  0.23 cusr  0.09 csys =  0.37 CPU)
Result: FAIL

The three test files passed on blead on FreeBSD-12 at 68f1b6d

[jkeenan]

Result: FAIL

The three test files passed on blead on FreeBSD-12 at 68f1b6d

And they passed on FreeBSD-12 at e3ccada.

But the three tests passed on your branch on OpenBSD-6.9.

[Leont]

When I tried this branch on FreeBSD-12, ./Configure appeared to run well as did make. But I got these test failures:

Those don't look like they would be related

[jkeenan]

Manually merged to blead and pushed to origin in commit 813d4ab.

Today, I could not reproduce the test failures I was observing yesterday. In addition, to testing the commit I just pushed, I also created a local branch based on e3ccada (where I was not observing test failures), then cherry-picked on to it 3e05d64, 8d469d0 and 813d4ab. In other words, I re-ordered the commits with @Corion's makedepend changes and @Leont's correction applied back-to-back. That configured, built and tested satisfactorily. Since that worked, I then took the simpler approach of merging @Leont's branch into blead, which was what got pushed to origin just now.