Reword discussion of /d regexp modifier. #19087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FGasper
force-pushed
the
fix_utf8_verbiage_in_perlre
branch
3 times, most recently
from
5fbaad5
to
c42e874
Compare
The phrasing as it stood confused UTF8-flagged strings with “UTF-8 encoded”. The latter term should refer to strings that the Perl application has actually encode()d, which probably *won’t* be UTF8-flagged and thus won’t, per /d modifier rules, get the Unicode treatment. This also removes an incorrect statement about only ASCII characters matching in the absence of (the UTF8 flag). This is trivially false given that "\xff" =~ /\xff/ is truthy. This also reorders and rewords some parts in an attempt to clarify that new code should avoid this flag, including use of the 'unicode_strings' feature to avoid implicit use.
I believe this was clumsily attempting to reference that character classes like |
Grinnz
approved these changes
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The phrasing as it stood confused UTF8-flagged strings with
“UTF-8 encoded”. The latter term should refer to strings that the
Perl application has actually encode()d, which probably won’t
be UTF8-flagged and thus won’t, per /d modifier rules, get the Unicode
treatment.
This also reorders and rewords some parts in an attempt to clarify that
new code should avoid this flag, including use of the 'unicode_strings'
feature to avoid implicit use.