Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't overwrite the faked up type details for hv-with-aux #19200

Closed
wants to merge 1 commit into from

Conversation

tonycoz
Copy link
Contributor

@tonycoz tonycoz commented Oct 18, 2021

Detected by coverity as:

340472 Unused value

An assigned value that is never used may represent unnecessary computation, an incorrect algorithm, or possibly the need for cleanup or refactoring.

In Perl_sv_clear: A value assigned to a variable is never used. (CWE-563)

@tonycoz tonycoz requested a review from nwc10 October 18, 2021 22:14
@nwc10
Copy link
Contributor

nwc10 commented Oct 19, 2021

Oops. "Thanks applied".

That would have been "leaking" pointers to bodies allocated from arenas, but would never have shown up under any leak checker. With -DPURIFY arenas aren't used, so everything is just malloc/free, and so bodies are passed to free without "thinking too hard" about what the "body details" metadata says to do. Without -DPURIFY bodies would themselves leak, but the arena doesn't leak, so that would be correctly freed at interpreter full destruction, and nothing would have realised.

@nwc10 nwc10 closed this Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants