ExtUtils::CBuilder - print out commands being run in usable form #19701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haarg
added
the
defer-next-dev
When not set to be quiet, the system commands being run are printed out before running them. This can assist with diagnosing issues. It is implied that this is a command that could be run by a user. Since the command is internally run with system using list form, it does not involve the shell, and does not need any extra quoting. The printed out command however, would be run by a user through a shell. Just joining the arguments with spaces will not quote them correctly for use through a shell. Add a new method for quoting a string for the shell. And use this method when printing out the command line that we are running.
haarg
force-pushed
the
haarg/eucb-print-real-commands
branch
from
38ccff3
to
b864688
Compare
haarg
removed
the
defer-next-dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When not set to be quiet, the system commands being run are printed out
before running them. This can assist with diagnosing issues. It is
implied that this is a command that could be run by a user.
Since the command is internally run with system using list form, it does not
involve the shell, and does not need any extra quoting. The printed out
command however, would be run by a user through a shell. Just joining
the arguments with spaces will not quote them correctly for use through
a shell.
Add a new method for quoting a string for the shell. And use this method
when printing out the command line that we are running.