New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add builtin::export_lexically #19895
Conversation
14ccf16
to
7978e66
Compare
Thanks @ilmari. Comments addressed and force-pushed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
7978e66
to
0736d65
Compare
#19857 is still a problem here:
|
Seeing as that's a problem with lexical subs in general, not specifically with exporting them, I don't think that should block this. |
P5P requests that this be expanded into a full RFC. I am now in the process of writing that. Until that's agreed, we should not merge this (but it can be referenced as a prototype implementation) |
RFC now written and PR raised: Perl/PPCs#20 |
9232cab
to
c6703ec
Compare
… into helper functions
As per RFC 0020
c6703ec
to
c357ed7
Compare
Adds a
builtin::
function for performing the lexical-export behaviour, so that new code can do the same trickery that corebuiltin::
itself achieves.